virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1406741496
> we are changing the public API by changing the signature of cleanup(Log log, java.io.Closeable... closeables) to cleanup(Logger log, java.io.Closeable... closeables). This is why I don't see that removing the method is any worse. The salt justification for retention would be "it is slightly easier to migrate if you already have an slf4j instance" Valid point. I am fine either ways. > we MUST NOT have hard coded log4j references in production code, especially not anything which may be used client-side. Server side we may have a bit more flexibility but I think it would be bad too put those log for Joe references in as (a) that code may be copied into client side classes and (b) I feel making changes now we may as well be more independent here. I wish we didn't have log4j hardcoded but we have it at several places already. But no worries, replacing them with slf4j before we finally migrate to lo4j2 would be my next set of sub-tasks. I need to tackle them carefully because we have too much dynamically updated appenders, which is not good, but I would move forward with the consensus we have on parent Jira HADOOP-16206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
