steveloughran commented on code in PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#discussion_r1171077119
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -3000,16 +3017,21 @@ private long getPutRequestLength(PutObjectRequest
putObjectRequest) {
*
* Retry Policy: none.
* @param request request
+ * @param durationTrackerFactory duration tracker factory for operation
* @return the result of the operation.
* @throws AmazonClientException on problems
*/
@Retries.OnceRaw
- UploadPartResult uploadPart(UploadPartRequest request)
+ UploadPartResult uploadPart(UploadPartRequest request,
+ final DurationTrackerFactory durationTrackerFactory)
throws AmazonClientException {
long len = request.getPartSize();
incrementPutStartStatistics(len);
try {
- UploadPartResult uploadPartResult = s3.uploadPart(request);
+ UploadPartResult uploadPartResult = trackDurationOfSupplier(
+ nonNullDurationTrackerFactory(durationTrackerFactory),
+ OBJECT_PUT_REQUESTS.getSymbol(), () ->
Review Comment:
actually, we may want o track as a MULTIPART_PUT_REQUEST to split stats
cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
