steveloughran commented on code in PR #5548:
URL: https://github.com/apache/hadoop/pull/5548#discussion_r1171080025
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java:
##########
@@ -31,21 +31,29 @@
import java.util.concurrent.TimeUnit;
import com.amazonaws.AmazonClientException;
-import org.apache.hadoop.util.Preconditions;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.InvalidRequestException;
import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.s3a.api.UnsupportedRequestException;
import org.apache.hadoop.fs.s3a.auth.NoAuthWithAWSException;
import org.apache.hadoop.io.retry.RetryPolicies;
import org.apache.hadoop.io.retry.RetryPolicy;
import org.apache.hadoop.net.ConnectTimeoutException;
+import org.apache.hadoop.util.Preconditions;
-import static org.apache.hadoop.io.retry.RetryPolicies.*;
-
-import static org.apache.hadoop.fs.s3a.Constants.*;
+import static org.apache.hadoop.fs.s3a.Constants.RETRY_INTERVAL;
Review Comment:
roll back to reduce backport pain
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java:
##########
@@ -93,12 +101,15 @@ public class S3ARetryPolicy implements RetryPolicy {
/** Exponential policy for the base of normal failures. */
protected final RetryPolicy baseExponentialRetry;
- /** Idempotent calls which raise IOEs are retried.
- * */
+ /**
+ * Idempotent calls which raise IOEs are retried.
+ */
protected final RetryPolicy retryIdempotentCalls;
- /** Policy for throttle requests, which are considered repeatable, even for
- * non-idempotent calls, as the service rejected the call entirely. */
+ /**
+ * Policy for throttle requests, which are considered repeatable, even for
+ * non-idempotent calls, as the service rejected the call entirely.
Review Comment:
revert
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java:
##########
@@ -184,6 +193,7 @@ public void test_010_CreateHugeFile() throws IOException {
Statistic putRequestsActive = Statistic.OBJECT_PUT_REQUESTS_ACTIVE;
Statistic putBytesPending = Statistic.OBJECT_PUT_BYTES_PENDING;
+
Review Comment:
cut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
