[ 
https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729160#comment-17729160
 ] 

Ayush Saxena commented on HADOOP-18207:
---------------------------------------

Waited a day, we are still there, if it was my own review/code, I would have 
reverted there itself, gave timezone benefits, I have reverted this change now. 
Please fix the test, {*}validate the Jenkins result{*}, Get some binding vote 
to review it and please merge it again. if it is convincing.

I indeed tried to review and put my +1 there but I backed off at 
([https://github.com/apache/hadoop/pull/5503#discussion_r1199923215|https://github.com/apache/hadoop/pull/5503#discussion_r1199614640])

PS If this whole exercise and related change is incompatible, I hope there is 
agreement from everyone, not just one.

I indeed revert my own even based on minor doubts, even if it is not the 
culprit, to ensure others are not 
impacted([https://github.com/apache/hadoop/pull/5549#issuecomment-1515719853])

> Introduce hadoop-logging module
> -------------------------------
>
>                 Key: HADOOP-18207
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18207
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Duo Zhang
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>
> There are several goals here:
>  # Provide the ability to change log level, get log level, etc.
>  # Place all the appender implementation(?)
>  # Hide the real logging implementation.
>  # Later we could remove all the log4j references in other hadoop module.
>  # Move as much log4j usage to the module as possible.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to