[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729167#comment-17729167 ]
Viraj Jasani commented on HADOOP-18207: --------------------------------------- created PR with addendum included [https://github.com/apache/hadoop/pull/5717] Ayush sir, sorry you had to do this but you could have given a little more time considering Wei-Chiu's timezone still has weekend (ever since PR was merged)? :) anyways, no worries now we have new PR so we should get jenkins results in 24 hr (as the changes are across almost all modules) {quote}Side Note: Good to check the Jenkins results usually before merging despite any external/trust factors {quote} This was an oversight from my side, not from any reviewers. What happens when we have full QA results, we see _*3 mapreduce tests and 1 hdfs (TestDirectoryScanner) failures*_ most of the times, hence 4 test classes would usually be present but sometimes TestDirectoryScanner would not be present so we might see only 3 test classes in failures. When the last QA results came (before PR merge, with latest merge conflict resolution), somehow i looked at 3 mapreduce failures and 1 hdfs failure but didn't realize that the recent failure is not TestDirectoryScanner and rather it's rbf test failure. The next QA results were posted on PR after the PR was merged, and that is when i immediately realized that we have a new test class and that is not TestDirectoryScanner and hence created addendum PR. I hope this explanation helps. > Introduce hadoop-logging module > ------------------------------- > > Key: HADOOP-18207 > URL: https://issues.apache.org/jira/browse/HADOOP-18207 > Project: Hadoop Common > Issue Type: Sub-task > Reporter: Duo Zhang > Assignee: Viraj Jasani > Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > > There are several goals here: > # Provide the ability to change log level, get log level, etc. > # Place all the appender implementation(?) > # Hide the real logging implementation. > # Later we could remove all the log4j references in other hadoop module. > # Move as much log4j usage to the module as possible. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org