mukund-thakur commented on PR #6789: URL: https://github.com/apache/hadoop/pull/6789#issuecomment-2223904082
> @mukund-thakur thanks, altered the tests and tried to clarify the immutability. > > One final thought: should we have a default list of enum values to set if, when parsing the config string, the string isn't found? > > Currently if nothing is found we return the empty set. I am good with an empty set. What is the default value you are thinking? create is already getting added based on the create perf flag explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org