[
https://issues.apache.org/jira/browse/HADOOP-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004830#comment-18004830
]
ASF GitHub Bot commented on HADOOP-19618:
-----------------------------------------
slfan1989 opened a new pull request, #7800:
URL: https://github.com/apache/hadoop/pull/7800
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
JIRA: HADOOP-19618. Replace AssumptionViolatedException with
TestAbortedException.
In JUnit 4, org.junit.internal.AssumptionViolatedException is used to
indicate assumption failure and skip the test. However,
AssumptionViolatedException is an implementation in JUnit 4, and in JUnit 5, we
can use TestAbortedException to replace AssumptionViolatedException.
TestAbortedException is used to indicate that a test has been aborted, and
it can be used to replace AssumptionViolatedException. However, it is not
directly related to assumption failure and is more commonly used in situations
where the test needs to be aborted during execution.
### How was this patch tested?
Junit Test.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Replace AssumptionViolatedException with TestAbortedException
> -------------------------------------------------------------
>
> Key: HADOOP-19618
> URL: https://issues.apache.org/jira/browse/HADOOP-19618
> Project: Hadoop Common
> Issue Type: Improvement
> Components: test
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
>
> In JUnit 4, {{org.junit.internal.AssumptionViolatedException}} is used to
> indicate assumption failure and skip the test. However,
> {{AssumptionViolatedException}} is an implementation in JUnit 4, and in JUnit
> 5, we can use {{TestAbortedException}} to replace
> {{{}AssumptionViolatedException{}}}.
> {{TestAbortedException}} is used to indicate that a test has been aborted,
> and it can be used to replace {{{}AssumptionViolatedException{}}}. However,
> it is not directly related to assumption failure and is more commonly used in
> situations where the test needs to be aborted during execution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
