[ https://issues.apache.org/jira/browse/HADOOP-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18007676#comment-18007676 ]
ASF GitHub Bot commented on HADOOP-19618: ----------------------------------------- slfan1989 commented on PR #7800: URL: https://github.com/apache/hadoop/pull/7800#issuecomment-3081967117 @steveloughran Thank you for your message — I fully agree with your perspective. From a long-term standpoint, we do need to plan the overall testing strategy of the project more systematically, building a more robust assertion framework around AssertJ and fully leveraging the advanced features provided by JUnit 5. At present, removing the dependency on JUnit 4 is likely a more pressing priority. I’ve initiated a discussion covering several topics, including the removal of JDK 8 support, deprecation of compatibility with end-of-life (EOL) operating systems, and future support for JDK 17. I will make sure to include your suggestions as part of this discussion. Looking forward to your response. cc: @cnauroth @pan3793 > Replace AssumptionViolatedException with TestAbortedException > ------------------------------------------------------------- > > Key: HADOOP-19618 > URL: https://issues.apache.org/jira/browse/HADOOP-19618 > Project: Hadoop Common > Issue Type: Improvement > Components: test > Reporter: Shilun Fan > Assignee: Shilun Fan > Priority: Major > Labels: pull-request-available > > In JUnit 4, {{org.junit.internal.AssumptionViolatedException}} is used to > indicate assumption failure and skip the test. However, > {{AssumptionViolatedException}} is an implementation in JUnit 4, and in JUnit > 5, we can use {{TestAbortedException}} to replace > {{{}AssumptionViolatedException{}}}. > {{TestAbortedException}} is used to indicate that a test has been aborted, > and it can be used to replace {{{}AssumptionViolatedException{}}}. However, > it is not directly related to assumption failure and is more commonly used in > situations where the test needs to be aborted during execution. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org