[ 
https://issues.apache.org/jira/browse/HADOOP-19618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18006610#comment-18006610
 ] 

ASF GitHub Bot commented on HADOOP-19618:
-----------------------------------------

steveloughran commented on PR #7800:
URL: https://github.com/apache/hadoop/pull/7800#issuecomment-3073077786

   maybe we should create our own exceptions for assumption failures, aborted, 
timed out and use in our code; they could be subclasses of the JUnit 
equivalent, but give us a bit more independence in future. 




> Replace AssumptionViolatedException with TestAbortedException
> -------------------------------------------------------------
>
>                 Key: HADOOP-19618
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19618
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>
> In JUnit 4, {{org.junit.internal.AssumptionViolatedException}} is used to 
> indicate assumption failure and skip the test. However, 
> {{AssumptionViolatedException}} is an implementation in JUnit 4, and in JUnit 
> 5, we can use {{TestAbortedException}} to replace 
> {{{}AssumptionViolatedException{}}}.
> {{TestAbortedException}} is used to indicate that a test has been aborted, 
> and it can be used to replace {{{}AssumptionViolatedException{}}}. However, 
> it is not directly related to assumption failure and is more commonly used in 
> situations where the test needs to be aborted during execution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to