adoroszlai commented on code in PR #8186: URL: https://github.com/apache/hadoop/pull/8186#discussion_r3029088837
########## pom.xml: ########## @@ -525,7 +525,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <plugin> <groupId>org.owasp</groupId> <artifactId>dependency-check-maven</artifactId> - <version>${dependency-check-maven.version}</version> + <version>${owasp-maven-plugin.version}</version> + <configuration> + <assemblyAnalyzerEnabled>false</assemblyAnalyzerEnabled> + <ossindexAnalyzerEnabled>false</ossindexAnalyzerEnabled> + </configuration> Review Comment: Can you please explain - why these are being disabled, - whether this change is necessary for the fix, - what about dozens of other analyzers? `assemblyAnalyzerEnabled` seems to be related to .NET. Plugin doc seems to indicate setting it is not needed for Hadoop, since > specific analyzers will automatically disable themselves if no file types that they support are detected ########## pom.xml: ########## @@ -125,7 +125,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <maven-compiler-plugin.version>3.10.1</maven-compiler-plugin.version> <cyclonedx.version>2.9.1</cyclonedx.version> <docker-maven-plugin.version>0.29.0</docker-maven-plugin.version> - + <owasp-maven-plugin.version>12.1.9</owasp-maven-plugin.version> Review Comment: Instead of adding a new property, please update the existing one: `dependency-check-maven.version`. Not only does this reduce change, it may better match existing naming convention. On a related note, a newer version of the plugin is already available: https://github.com/dependency-check/DependencyCheck/releases/tag/v12.2.0 ########## pom.xml: ########## @@ -647,17 +651,6 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <artifactId>maven-checkstyle-plugin</artifactId> <version>${maven-checkstyle-plugin.version}</version> </plugin> - <plugin> - <!-- OWASP's dependency-check plugin will scan the third party - dependencies of this project for known CVEs (security - vulnerabilities against them). It will produce a report - in target/dependency-check-report.html. To invoke, run - 'mvn dependency-check:aggregate'. - --> - <groupId>org.owasp</groupId> - <artifactId>dependency-check-maven</artifactId> - <version>${dependency-check-maven.version}</version> - </plugin> Review Comment: Can you please explain why this is being removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
