adoroszlai commented on code in PR #8186: URL: https://github.com/apache/hadoop/pull/8186#discussion_r3029088837
########## pom.xml: ########## @@ -525,7 +525,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <plugin> <groupId>org.owasp</groupId> <artifactId>dependency-check-maven</artifactId> - <version>${dependency-check-maven.version}</version> + <version>${owasp-maven-plugin.version}</version> + <configuration> + <assemblyAnalyzerEnabled>false</assemblyAnalyzerEnabled> + <ossindexAnalyzerEnabled>false</ossindexAnalyzerEnabled> + </configuration> Review Comment: Can you please explain - why these are being disabled, - whether this change is necessary for the fix, - what about dozens of other analyzers? `assemblyAnalyzerEnabled` is related to .NET. The plugin's doc says: > specific analyzers will automatically disable themselves if no file types that they support are detected so it seems to be unnecessary to explicitly set it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
