edwardcapriolo commented on code in PR #8186:
URL: https://github.com/apache/hadoop/pull/8186#discussion_r3030780432


##########
pom.xml:
##########
@@ -647,17 +651,6 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/x
         <artifactId>maven-checkstyle-plugin</artifactId>
         <version>${maven-checkstyle-plugin.version}</version>
       </plugin>
-      <plugin>
-        <!-- OWASP's dependency-check plugin will scan the third party
-             dependencies of this project for known CVEs (security
-             vulnerabilities against them). It will produce a report
-             in target/dependency-check-report.html. To invoke, run

Review Comment:
   Nothing consumes it. It is only a tool to provide an adhoc audit



##########
pom.xml:
##########
@@ -647,17 +651,6 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/x
         <artifactId>maven-checkstyle-plugin</artifactId>
         <version>${maven-checkstyle-plugin.version}</version>
       </plugin>
-      <plugin>
-        <!-- OWASP's dependency-check plugin will scan the third party
-             dependencies of this project for known CVEs (security
-             vulnerabilities against them). It will produce a report
-             in target/dependency-check-report.html. To invoke, run
-             'mvn dependency-check:aggregate'.
-        -->
-        <groupId>org.owasp</groupId>
-        <artifactId>dependency-check-maven</artifactId>
-        <version>${dependency-check-maven.version}</version>
-      </plugin>

Review Comment:
   Its moved. Not removed



##########
pom.xml:
##########
@@ -525,7 +525,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/x
         <plugin>
           <groupId>org.owasp</groupId>
           <artifactId>dependency-check-maven</artifactId>
-          <version>${dependency-check-maven.version}</version>
+          <version>${owasp-maven-plugin.version}</version>
+          <configuration>
+            <assemblyAnalyzerEnabled>false</assemblyAnalyzerEnabled>
+            <ossindexAnalyzerEnabled>false</ossindexAnalyzerEnabled>
+          </configuration>

Review Comment:
   ossindexAnalyzerEnabled this one requires an extra subscription/login to a 
sontype service. If you dont disable it your get error messages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to