pan3793 commented on code in PR #8433: URL: https://github.com/apache/hadoop/pull/8433#discussion_r3107022876
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcWritable.java: ########## @@ -33,7 +33,14 @@ import org.apache.hadoop.thirdparty.protobuf.CodedOutputStream; import org.apache.hadoop.thirdparty.protobuf.Message; -// note anything marked public is solely for access by SaslRpcClient +/** + * Marshalling support, for hadoop shaded protobuf and legacy + * protobuf 2.5. Review Comment: do you have a plan to cut protobuf 2.5 thoroughly? protobuf 3-based ProtobufRpcEngine2 has been introduced in HADOOP-17046 (3.3.0, 6 years ago), also Hadoop 3.2 has reached EOL, I think we have already given downstream projects enough time to allow them to migrate from protobuf 2.5 to protobuf 3.x seamlessly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
