pan3793 commented on code in PR #8433:
URL: https://github.com/apache/hadoop/pull/8433#discussion_r3129067760
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcWritable.java:
##########
@@ -33,7 +33,14 @@
import org.apache.hadoop.thirdparty.protobuf.CodedOutputStream;
import org.apache.hadoop.thirdparty.protobuf.Message;
-// note anything marked public is solely for access by SaslRpcClient
+/**
+ * Marshalling support, for hadoop shaded protobuf and legacy
+ * protobuf 2.5.
+ * It originally supported hadoop Writables for the WritableRPCEngine;
+ * that is no removed. All that is retained is the name.
+ * Anything marked public is solely for access by SaslRpcClient
+ */
+// note
Review Comment:
nit: restore original note statement
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -3642,6 +3649,8 @@ private void setupResponse(RpcCall call,
call.setResponse(ByteBuffer.wrap(response));
}
+
+
Review Comment:
nit: revert unnecessary changes
##########
hadoop-hdfs-project/pom.xml:
##########
@@ -28,6 +28,7 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
<description>Apache Hadoop HDFS Project</description>
<name>Apache Hadoop HDFS Project</name>
<packaging>pom</packaging>
+ <!-- ignore this line -->
Review Comment:
remove after passing yetus checks
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -3660,7 +3669,6 @@ private byte[] setupResponseForWritable(
}
}
-
Review Comment:
nit: ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
