steveloughran commented on code in PR #8433: URL: https://github.com/apache/hadoop/pull/8433#discussion_r3107298444
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcWritable.java: ########## @@ -33,7 +33,14 @@ import org.apache.hadoop.thirdparty.protobuf.CodedOutputStream; import org.apache.hadoop.thirdparty.protobuf.Message; -// note anything marked public is solely for access by SaslRpcClient +/** + * Marshalling support, for hadoop shaded protobuf and legacy + * protobuf 2.5. Review Comment: good point. the issue was always hbase 1. now we are cleaning up, getting rid of obsolete rpc stuff is good. someone should ping hbase dev list though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
