[ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13575624#comment-13575624 ]
Surenkumar Nihalani commented on HADOOP-9112: --------------------------------------------- Turns out, negative look ahead isn't supported by extended regular expression. I am going to use perl option in grep. However, on Mac, the grep doesn't support perl regex while GNU's grep does. Can anyone confirm that the Jenkins system uses GNU grep? If not, there is an option in grep to return lines that don't match a pattern and I can simulate it, but negative lookahead would be robust. > test-patch should -1 for @Tests without a timeout > ------------------------------------------------- > > Key: HADOOP-9112 > URL: https://issues.apache.org/jira/browse/HADOOP-9112 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Todd Lipcon > Assignee: Surenkumar Nihalani > Attachments: HADOOP-9112-1.patch > > > With our current test running infrastructure, if a test with no timeout set > runs too long, it triggers a surefire-wide timeout, which for some reason > doesn't show up as a failed test in the test-patch output. Given that, we > should require that all tests have a timeout set, and have test-patch enforce > this with a simple check -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira