[
https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581329#comment-13581329
]
Robert Joseph Evans commented on HADOOP-9112:
---------------------------------------------
A quick look seems reasonable, but I have not had time to dig deeply into the
REGEXP yet. Could you replace the grep with $GREP and add in similar code to
support $TR instead of calling tr directly?
Also what operating systems/distros have you run this on? We want to be fairly
conservative in adding in new dependencies, and want to be sure that it at
least works out of the box on stock Ubuntu, RedHat, and MacOS X.
> test-patch should -1 for @Tests without a timeout
> -------------------------------------------------
>
> Key: HADOOP-9112
> URL: https://issues.apache.org/jira/browse/HADOOP-9112
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Todd Lipcon
> Assignee: Surenkumar Nihalani
> Attachments: HADOOP-9112-1.patch, HADOOP-9112-2.patch,
> HADOOP-9112-3.patch
>
>
> With our current test running infrastructure, if a test with no timeout set
> runs too long, it triggers a surefire-wide timeout, which for some reason
> doesn't show up as a failed test in the test-patch output. Given that, we
> should require that all tests have a timeout set, and have test-patch enforce
> this with a simple check
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
