[
https://issues.apache.org/jira/browse/HADOOP-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378933#comment-14378933
]
Allen Wittenauer commented on HADOOP-11745:
-------------------------------------------
Ha! I've been thinking more and more about HADOOP-10854 and what kind of things
should be done for it. This particular issue (shellcheck part of test-patch)
was going to be something of immediate priority on that list!
So I'm glad to see this here. :D
One of the things that I've been puzzling over was the best way to mark thing
that we know are unfixable (HADOOP_OPTS handling in hadoop-functions.sh, for
example). I've been meaning to look at how exceptions are handled for some of
the Java-bits but I hadn't gotten that far yet.
One of the big gotchas with putting this into the pipeline is we need to audit
*ALL* of the shell scripts to make sure they pass. At this point, I think/hope
the only things left to really look at is dev-support itself.
> Incorporate ShellCheck static analysis into Jenkins pre-commit builds.
> ----------------------------------------------------------------------
>
> Key: HADOOP-11745
> URL: https://issues.apache.org/jira/browse/HADOOP-11745
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, scripts
> Reporter: Chris Nauroth
> Priority: Minor
>
> During the shell script rewrite on trunk, we've been using ShellCheck as a
> static analysis tool to catch common errors. We can incorporate this
> directly into Jenkins pre-commit builds. Jenkins can reply with a -1 on
> shell script patches that introduce new ShellCheck warnings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
