[
https://issues.apache.org/jira/browse/HADOOP-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378985#comment-14378985
]
Chris Nauroth commented on HADOOP-11745:
----------------------------------------
bq. I've been meaning to look at how exceptions are handled for some of the
Java-bits but I hadn't gotten that far yet.
I think the closest analogy in the Java world is our Findbugs exclude files.
These are XML files that describe points in the code that trigger Findbugs
warnings that we have agreed are spurious. I think the {{shellcheck disable}}
comments are similar. I think if we keep using that, then it would work out
fine.
bq. At this point, I think/hope the only things left to really look at is
dev-support itself.
Yes, that's a good point. I do see a lot of warnings in the dev-support
scripts. If this gets intractable, then I suppose as a first step we could
chicken out and filter dev-support from the ShellCheck results. :-)
> Incorporate ShellCheck static analysis into Jenkins pre-commit builds.
> ----------------------------------------------------------------------
>
> Key: HADOOP-11745
> URL: https://issues.apache.org/jira/browse/HADOOP-11745
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, scripts
> Reporter: Chris Nauroth
> Priority: Minor
>
> During the shell script rewrite on trunk, we've been using ShellCheck as a
> static analysis tool to catch common errors. We can incorporate this
> directly into Jenkins pre-commit builds. Jenkins can reply with a -1 on
> shell script patches that introduce new ShellCheck warnings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
