[ 
https://issues.apache.org/jira/browse/HADOOP-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379046#comment-14379046
 ] 

Allen Wittenauer commented on HADOOP-11745:
-------------------------------------------

Looking at this now, shellcheck does support spitting out something that is 
checkstyle-compatible, but I'm not sure how to integrate that into our build 
setup.

 Someone asked me the other day if I was going to fix dev-support too since 
technically it is mostly shell code. I guess I'll probably take a look at the 
dev-support/ stuff and start whacking at it. 

> Incorporate ShellCheck static analysis into Jenkins pre-commit builds.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-11745
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11745
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, scripts
>            Reporter: Chris Nauroth
>            Priority: Minor
>
> During the shell script rewrite on trunk, we've been using ShellCheck as a 
> static analysis tool to catch common errors.  We can incorporate this 
> directly into Jenkins pre-commit builds.  Jenkins can reply with a -1 on 
> shell script patches that introduce new ShellCheck warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to