----- Original Message ----- From: <[EMAIL PROTECTED]> To: "Jakarta Commons Developers List" <[EMAIL PROTECTED]> Sent: Thursday, February 21, 2002 12:00 PM Subject: RE: Commons Util 1.0 release candidate 1
> > > On Thu, 21 Feb 2002, Waldhoff, Rodney wrote: > > > I'm not that familiar with StringUtils, but from a quick glance I see only: > > > > StringUtils.soundex(String) > > StringUtils.metaphone(String) > > StringUtils.isMetaphoneEqual(String,String) > > > > which seem to be in the wrong place anyway. > > > > This is part of the problem with a monolithic "util" package--it's too easy > > to bleed functionality, responsiblity and interdependencies between the > > classes. Having distinct components would force us to put more > > consideration into the partitioning. > > > > If we applied the single responsiblity principle I think we'd see a much > > different organization of commons-util, at both the package and class level. > > > > Yep. I'm in agreement with these being removed from StringUtils and > Metaphone/Soundex both going into codec (if codec committers agree). How > would SoundexComparator fit into this? Or should I just remopve it as an > unlikely to be useful/too easy to code yourself component? As I only added > it last night, I'm pretty sure no one would care :) > Could the comparator live in the codec package as well? It may be too specialized for Collections. - Morgan _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>