Biggest problem there is CVS. It's a fault of CVS' probably, but it can be quite painful to see diff's that are encumbered with restylings.
In the situation you describe, in which the primary contributor [or some such designation] has changed, then a restyle sounds fine. I do think that the restyle should be done separately from any other change and a nice comment like 'Restyled imports' or something be used. Otherwise the audit-trail gets ugly, even with options like --ignore-white-space. Hen On Wed, 2 Apr 2003, SPRINGER,IAN (HP-NewJersey,ex1) wrote: > I wouldn't call that a standard. > > I disagree that restyling is rude, particularly when the original author > might not still be the primary contributor to the class, or even a > contributor at all. Also, it's easy enough to use Jalop, IntelliJ, or > whatever to restyle code back to how you like it. > > | -----Original Message----- > | From: Henri Yandell [mailto:[EMAIL PROTECTED] > | Sent: Wednesday, April 02, 2003 4:14 PM > | To: Jakarta Commons Developers List > | Subject: RE: [collections] XxxUtils inner classes > | > | > | > | Yep. Standard is: > | > | Match the style of the source, unless it's expressly stated in the Sun > | coding standard. > | > | > | Restyling source is rude :) > | > | Hen > | > | On Wed, 2 Apr 2003, SPRINGER,IAN (HP-NewJersey,ex1) wrote: > | > | > I agree there are two camps. A decent way to compromise is > | to use explicit > | > imports unless there are n or more imports from a > | particular package. > | > > | > I think more important than which style is used, is that > | the same style is > | > used consistently across a project. Doesn't Apache have any > | standard defined > | > for this? > | > > | > | -----Original Message----- > | > | From: Alex Chaffee / Purple Technology [mailto:[EMAIL PROTECTED] > | > | Sent: Wednesday, April 02, 2003 4:06 PM > | > | To: Shapira, Yoav > | > | Cc: Jakarta Commons Developers List; [EMAIL PROTECTED] > | > | Subject: Re: [collections] XxxUtils inner classes > | > | > | > | > | > | On Wed, Apr 02, 2003 at 03:10:51PM -0500, Shapira, Yoav wrote: > | > | > > | > | > Howdy, > | > | > > | > | > >import org.apache.commons.collections.* good. > | > | > > | > | > Import org.apache.commons.collections.[onlyTheClassYouNeed] > | > | is good. > | > | > > | > | > Import .* is annoying and all the jakarta projects should > | > | have import > | > | > cleanups as part of their build.xml IMHO. > | > | > | > | Oh, God, not this debate again. > | > | > | > | Look, there are two camps here, and I'm in the * camp and > | you're in > | > | the explicit-import camp. There's no need to structure > | things so that > | > | one camp is going to be angry, even if you don't agree with their > | > | reasons for being angry. Organizing classes by maximal cohesion > | > | should satisfy everyone. > | > | > | > | (If you like, I'd be happy to debate with you *off-list* > | and show you > | > | the error of your anal ways :-)) > | > | > | > | -- > | > | Alex Chaffee mailto:[EMAIL PROTECTED] > | > | Purple Technology - Code and Consulting > http://www.purpletech.com/ > > | jGuru - Java News and FAQs http://www.jguru.com/alex/ > > | Gamelan - the Original Java site http://www.gamelan.com/ > > | Stinky - Art and Angst http://www.stinky.com/ > > | > > | --------------------------------------------------------------------- > > | To unsubscribe, e-mail: [EMAIL PROTECTED] > > | For additional commands, e-mail: [EMAIL PROTECTED] > > | > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
