On Tue, Nov 13, 2007 at 09:29:09PM +0530, rahul wrote: > why is the CC defined as gcc ? (why not studio cc ?)
Either because at some point in the past whoever integrated xterm couldn't get it to compile with Studio or because the Makefile was copied from another component which couldn't be compiled with Studio. It's also possible that at the time, it was a given that few things would compile with Studio, so gcc was assumed. Mike might know the real answer. > | - resize.patch, menu-include.patch: Can you provide a short explanation of > | why you needed to add the former and remove the latter? The last build > | I did was of 222, and I didn't need to make either change. > > (Do you mean I should update this in comments?) No, your explanations here are enough. > +resize.patch > The termio struct complains about getting redefined when xtermcap.h is > included in this file. Since the file compiles correctly with out > including xtermcap.h I assume no functionality is broken. Hm. Please test. And please send Thomas a note; he may have some idea of what's going on. > - menu-include.patch > it just changes <menu.h> to "menu.h" but this compilation completes > successfully without this. Okay. Looks like an -I. snuck in to CPPFLAGS sometime since the patch was added, which is good. > | Don't forget to update README.sfw and METADATA, too. > done. Did you have to add the README fresh? There is, or at least was, a README.sfw file that talked a little about what patches were applied and how it was built. Is that no longer there? Danek
