On Sunday 29 June 2008, Phil Dibowitz wrote: > Did you see my comments/suggestions on the output for IR learning? This > code doesn't seem to follow that...
The only comment I found was: > * Hmm - should be be showing pulses and details in non-verbose > mode? I would think that _dump_new_code() should be wrapped in if > ((*options).verbose). As long as we don't have that kind of automatic signal quality check that seems to be in the original Logitech drivers, my personal preference (apparently) would be to keep the 'ASCII-plot' in. Since you didn't comment on the two sample sessions I posted (with plots), I thought it would be OK and just promoted some 'very verbose' extra output from '(*options).verbose' to '#ifdef _DEBUG'. So, you think the 'plot' would be too much output for non-verbose, or possibly even confuse less-experienced users? Andreas ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
