On Fri, 9 Aug 2013, Phil Dibowitz wrote:

> I would have this take the key, and then do:
>
>   start += strlen(key) + 1;

Yeah, that makes sense.  I'll address that in v3.

>> +    uint8_t pkts_to_send = wrlen / MH_MAX_DATA_SIZE;
>> +    if ((wrlen % MH_MAX_DATA_SIZE) != 0)
>> +        pkts_to_send++;
>> +    pkts_to_send++; // count is always one more than the actual count
>
> That's odd. Any idea why we claim we're going to send one more than we do?

Shrug?  I didn't design the MH protocol.  :-)  All I know is that it 
always sets the "count" to one more packet than it is actually going to 
send.  I'll add a comment, though.

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to