On 08/26/2013 08:19 PM, Scott Talbert wrote:
> The Harmony Link is an MH "remote."  Essentially it is a WiFi to IR bridge
> where you can issue commands on your smartphone via WiFI and the Link will
> convert them to IR to control your devices.  In order to support the Link,
> we had to add a few API calls to allow configuration of WiFI (SSID, key, etc)
> as well as account configuration (email, etc).  The Link does not receive its
> configuration via USB like other remotes - it receives it via WiFi.

Sorry for the delay.

Just one comment.

> It would be good if this could get faster turnaround.  I would like to get
> David his Link back at some point.

Yeah, sorry, I'll keep on top of this better.

> +    /*
> +     * Second parameter in the read file "ack" message is the data length.  
> Use
> +     * this to determine the number of packets we should expect.
> +     */
> +    uint32_t data_len = (rsp[7] << 24) + (rsp[8] << 16) + (rsp[9] << 8) +
> +        rsp[10];
> +    int pkts_to_read = data_len / MH_MAX_DATA_SIZE;
> +    if ((data_len % MH_MAX_DATA_SIZE) != 0)
> +        pkts_to_read++;
> +    pkts_to_read++; // count is always one more than the actual count

I was willing to buy that until I saw:

> +        pkts_to_read--;
> +        if (pkts_to_read == 1) {
> +            break;
> +        }

This. If you stop when you have one more to read, then really the original
number was correct, no?


-- 
Phil Dibowitz                             p...@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't matter
 and those who matter don't mind."
 - Dr. Seuss


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to