On Tue, 19 Apr 2016, Jeremy Kerr wrote:

> Currently, CRemoteMH::GetIdentity does a ReadFile, and creates a
> std::string from the resulting data.
>
> However, the buffer may not be null-terminated, so we may be using
> uninitialised data in the subsequent find_value calls (and the debug
> print).
>
> This change uses the string(const char* s, size_t n) constructor
> instead, so we only use the actual data returned from the sysinfo file.

Actually, from what I've seen the "strings" coming back from the remote 
are usually null terminated.  Are you seeing data where this is not the 
case?

Scott

------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to