[
https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johan Oskarsson updated HADOOP-3935:
------------------------------------
Attachment: HADOOP-3935.patch
This is an initial patch for review. Comments and suggestions are very welcome.
I have noticed the hadoop codebase is quite keen on inner classes so perhaps
this goes against some unwritten code guideline.
I have broken out the following classes into their own files:
BlockReceiver
BlockSender
DataXceiver
DataXceiverServer
PacketResponder
Throttler
It brings DataNode.java down from about 3000 to about 1000 lines and makes the
code easier to overview/navigate in my opinion.
I had to change the visibility of some variables in DataNode and pass in some
objects to the contructors in the above classes.
> Extract classes from DataNode.java
> ----------------------------------
>
> Key: HADOOP-3935
> URL: https://issues.apache.org/jira/browse/HADOOP-3935
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Attachments: HADOOP-3935.patch
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I
> suggest moving some of the classes out into their own files in the same
> package. This will also make it easier to see how the classes depend on each
> other and to see what code belongs where.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
