[
https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621934#action_12621934
]
Konstantin Shvachko commented on HADOOP-3935:
---------------------------------------------
This is a good idea to split the DataNode code. Some comments
- What is the reason for renaming DataXceiveServer to DataXceive-r-Server?
- I agree with Raghu PacketResponder is not a separate class and should be
inside BlockReceiver.
- I also think Throttler class should be contained in DataBlockScanner, because
this is the only reason it exists.
- Throttler can be renamed to something less general like BlockScannerThrottler
since it is not a subclass anymore.
- Throttler should not be public class and should contain public methods at all.
- The same is applicable to all other separated classes/methods unless it is
unavoidable.
- You should use the DataNode logger instead of creating new ones. E.g. for the
BlockSender it should look like
{code}
class BlockSender {
private static final Log LOG = DataNode.LOG;
}
{code}
This is important, because there are programs and scripts out there analyzing
logs.
- Could you please transform //-style and /*-style comments that are in front
of methods to JavaDoc-style /** */
especially if they have to be public.
> Extract classes from DataNode.java
> ----------------------------------
>
> Key: HADOOP-3935
> URL: https://issues.apache.org/jira/browse/HADOOP-3935
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Attachments: HADOOP-3935.patch
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I
> suggest moving some of the classes out into their own files in the same
> package. This will also make it easier to see how the classes depend on each
> other and to see what code belongs where.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
