[
https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621938#action_12621938
]
rangadi edited comment on HADOOP-3935 at 8/12/08 12:46 PM:
----------------------------------------------------------------
I haven't looked at the patch itself. To add to Konstantin's comments :
- better not make these classes public unless required.
- Throttler is used by both DataBlockScanner and data rebalancing (as an
argument to BlockSender). A separate class is ok. It is a pretty generic class
and in that sense usable by other parts.
Edit : typo
was (Author: rangadi):
I haven't looked at the patch itself. To add to Konstantin's comments :
- better not make these classes public unless required.
- Throttler is used by both DataBlockScanner and data rebalancing (as an
argument to BlockScanner). A separate class is ok. It is a pretty generic class
and in that sense usable by other parts.
> Extract classes from DataNode.java
> ----------------------------------
>
> Key: HADOOP-3935
> URL: https://issues.apache.org/jira/browse/HADOOP-3935
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Attachments: HADOOP-3935.patch
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I
> suggest moving some of the classes out into their own files in the same
> package. This will also make it easier to see how the classes depend on each
> other and to see what code belongs where.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
