In terms of monitoring the changes made to the jaxp sources, being in it's own 
repository makes that easy.
You can easily scan the changesets made to the repository and see when strange 
changesets appear at
  http://hg.openjdk.java.net/jdk8/jdk8/jaxp

If we folded the jaxp sources into the jdk repository, that becomes harder, but 
has other benefits which will
probably become more apparent as the jigsaw project gets integrated.

The other issue is how dependent the jaxp sources become on newer features in 
the jdk8 javac or apis.
Historically, your jaxp sources had to stay back on the older Java api and 
language, not sure how that
will change going forward, or if it will. Again, that's a little easier when 
it's part of the jdk repository where
the new apis are in the same repository. But we can deal with that when the 
time comes.

-kto

On Dec 27, 2011, at 10:21 AM, Joe Wang wrote:

> Thanks Kelly!
> 
> Indeed, that was the original intention when you designed the bundle process. 
> Besides the unfortunate download problem, it actually works great in terms of 
> guaranteeing that we have one single editable source.
> 
> Next, maybe we could start to work on migrating the jaxp project source into 
> the jdk. But it's the holiday season, we don't have to think too hard :). In 
> the meantime, we just have to make sure patches are applied to the jaxp 
> project first (through JIRA report for example) since that's how our dev/test 
> process is set up.
> 
> --Joe
> 
> On 12/24/2011 8:56 AM, Kelly O'Hair wrote:
>> Looks great to me.
>> 
>> There is still the issue of making sure the right people (like you :^) are 
>> the ones patching this code, so we know
>> what we have matches the public JAXP project.
>> 
>> -kto
>> 
>> On Dec 23, 2011, at 1:27 PM, Joe Wang wrote:
>> 
>>> Hi All,
>>> 
>>> We have prepared a jaxp update for 7u4. The listed changes have been posted 
>>> to the jdk7u-dev alias with "7u4 Request for approval for CR 7121110 - JAXP 
>>> 1.4.5 update 1 for 7u4".
>>> 
>>> With this update, we are adding jaxp sources back into the jdk7 repository, 
>>> which means we are abandoning the jaxp bundle download process. This is a 
>>> significant change. We'd like to hear if you have any concerns.  If no 
>>> objection, we'd like to push the change within the next week.
>>> 
>>> The webrev is here:  
>>> http://cr.openjdk.java.net/~joehw/jaxp145u1-changeset/webrev/
>>> 
>>> Thanks,
>>> Joe

Reply via email to