Laurent,
On 4/11/13 6:19 AM, Laurent Bourgès wrote:
Anthony, Mandy,
here the 4th patch:
http://jmmc.fr/~bourgesl/share/webrev-8010297.4/
Thanks for addressing the memory overhead concern and keeping this fix
for clients of PlatformLogger. Looks good and I saw that you caught
several existing bugs calling isLoggable with a mismatched level. I'd
really like to see if we can avoid the boilerplate "if (isLoggable(...))
logger.fine(....)" and help ease of development and I file a RFE (8012006).
src/solaris/classes/sun/awt/X11/XListPeer.java
Nit: line 1906 you remove isLoggable call here. Was it intentional (as
it doesn't call concatenate any string?)? I think it's better to use
the pattern consistently.
Approved and no need to regenerate a new webrev if you fix the above nit.
thanks
Mandy
It only contains awt / swing / net classes that use PlatformLogger (no code
modification).
Laurent
