On 4/11/13 8:43 AM, Laurent Bourgès wrote:
I don't understand if I should fix it or not ? src/solaris/classes/sun/awt/X11/XListPeer.java Nit: line 1906 you remove isLoggable call here. Was it intentional (as it doesn't call concatenate any string?)? I think it's better to use the pattern consistently. it's a mistake (cookie).
Please fix it.
Approved and no need to regenerate a new webrev if you fix the above nit. To fix it, I need to send you files as a new webrev ?
Anthony is going to sponsor for you and I think he asks for a webrev. So please send the latest webrev with this fix then.
Mandy
Laurent