Mandy, I'd really like to see if we can avoid the boilerplate "if (isLoggable(...)) logger.fine(....)" and help ease of development and I file a RFE (8012006).
Agreed but there is no easy way to have clear code and performance: - maybe JDK 8 Supplier may help - or a shorter syntax: logger.isDebug() or testing its effective level directly: if (logger.isDebug) - annotation syntax: @logCheck() but it is not straightforward to guess the correct level of the log statement ... I don't understand if I should fix it or not ? src/solaris/classes/sun/awt/X11/XListPeer.java > Nit: line 1906 you remove isLoggable call here. Was it intentional (as it > doesn't call concatenate any string?)? I think it's better to use the > pattern consistently. > it's a mistake (cookie). > Approved and no need to regenerate a new webrev if you fix the above nit. > To fix it, I need to send you files as a new webrev ? Laurent
