Kumar - the makefile changes look good to me.
Tim
On 09/ 7/13 03:50 AM, Staffan Larsen wrote:
This is a welcome change. I've looked at the serviceability test and the
changes look good except:
test/demo/jvmti/DemoRun.java
test/sun/tools/jhat/HatRun.java
- Looks like there are still some -d64 remnants that I wasn't expecting.
Thanks,
/Staffan
On 6 sep 2013, at 22:17, Kumar Srinivasan <kumar.x.sriniva...@oracle.com> wrote:
On 9/6/2013 12:21 PM, Alan Bateman wrote:
On 06/09/2013 17:47, Kumar Srinivasan wrote:
Hello,
Please review the changes to remove Solaris 32-bit binaries from JDK8 distros,
at this time the dual mode support in the launcher is being disabled.
Message regarding this:
http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-September/003159.html
The jdk changes are here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.0/
The top forest changes are here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.0/
I haven't studied the changes yet but I see you've updated
test/java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh. I don't think
you need the changes at L42-48, instead you can just "hg rm" the 32-bit
libraries that are in test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib.
Will do, I was wondering about those libraries.
You might want to bring the changes to serviceability-dev because of the change
to the JDI launching connector and the JDI tests.
cc'ed.
Thanks
Kumar
-Alan.
