Hello all; With the imminent promotion of JTReg 4.1b07 it's possible to finally consider completing this changeset!
http://cr.openjdk.java.net/~mduigou/JDK-8015068/2/webrev/ This updated webrev includes handling of the shared library permissions. Thanks, Mike On Aug 28 2013, at 04:11 , Alan Bateman <alan.bate...@oracle.com> wrote: > On 28/08/2013 00:17, Mike Duigou wrote: >> Hello all; >> >> I have updated the changeset for this issue based upon feedback from the >> earlier version. As a result of intervening work this version contains even >> more cleanup. >> >> http://cr.openjdk.java.net/~mduigou/JDK-8015068/1/webrev/ >> >> Since the last revision: >> >> - One open issue remains--handling of shared_library_permissions. The >> proposed patch uses a pattern rule, "jdk_%", rather than explicit make >> targets. This means the knowledge of which targets required >> shared_library_permissions has been lost. The shared_library_permissions >> target could be run unconditionally as part of prep but I am uncertain if >> this is reasonable. Alternatives? >> >> - The previously proposed behaviour of writing testoutput to the current >> directory if not ALT_OUTPUTDIR is provided has been changed in response to >> feedback. Output will now be written to jdk/testoutput and this directory >> has been added to the .hgignore. Since most people are expected to use only >> the root repo make which sets ALT_OUTPUTDIR it is not expected that this >> change will make any difference for most users. >> >> As before, testing of this patch requires using a source build of JTReg as >> it requires one fix that is not in the promoted builds. This changeset will >> not be integrated until after the next JTReg promotion. >> >> Mike >> > The updated webrev looks good to me too although I expect the output location > will be visited again in the future. > > (I like Kelly's suggestion for hazard pay for those working on these make > files). > > -Alan.
