On 26.6.2015 16:00, Alan Bateman wrote:
On 26/06/2015 14:38, Jan Lahoda wrote:
Uploaded a new iteration of the patch, reflecting the comments so far,
here:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.02/full/
A delta patch from previous iteration:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.02/delta/
Any feedback on this would be appreciated!
Thanks for the comments!
This looks okay although you might consider moving the initialization to
a initIDs (or some such method) that is called after the
System.loadLibrary. You'll see many examples of this already in the JDK.
Thanks for the comment - done that. Updated webrev:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.03/full/
Delta against the previous iteration:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.03/delta/
How does this look? Feedback is appreciated.
Thanks,
Jan
-Alan.