On Sep 29, 2015, at 1:46 PM, Steve Drach <steve.dr...@oracle.com> wrote: > >>> Please review the following webrev that adds support for multi-release jars >>> as specified in JEP-238. >>> >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8132734 >>> <https://bugs.openjdk.java.net/browse/JDK-8132734> >>> JEP 238: https://bugs.openjdk.java.net/browse/JDK-8047305 >>> <https://bugs.openjdk.java.net/browse/JDK-8047305> >>> Webrev: http://cr.openjdk.java.net/~psandoz/multiversion-jar/jar-webrev/ >>> <http://cr.openjdk.java.net/~psandoz/multiversion-jar/jar-webrev/> >>> … > >> Steve - is the webrev complete, just wondering as I don't see any tests. > > Yes it is complete. Oracle SQE has done the tests, and have tested the > changes. They will integrate the tests after this webrev is integrated. > I’ve been told that this is the way it’s done for new features.
For core-libs, unit tests are required to be integrated together with the feature. You should include the unit tests in this review. Mandy
