> What's the purpose of having a dedicated "JarFile.runtimeVersioned”?
Consistency, so getVersion returns the same version as the version set when JarFile was constructed. > Based on > its only usages at ln#356 and #381, it appears, shouldn't getVersion() simply > returns Release.valueOf(version)? That might be confusing. Also, having it consistent helps with testing. > > sherman > > On 01/27/2016 03:37 PM, Steve Drach wrote: >>> I'm still wondering about the phrase "root entry" as it continues to give >>> the impression (to me anyway) that it's a resource in the root directory. I >>> think "root" works in the JEP because it deals with simple resources like >>> A.class and B.class that are in the root directory but it's confusing when >>> there resources with a slash in the name. Add to this is the >>> META-INF/versions/<n> directories which are roots for the version specific >>> resources. I think part of the confusion is that the first mention of >>> "root entry" is in the second paragraph where it has "overrides the >>> unversioned root entry" without defining what it means. In summary, I'm >>> wondering whether you would be up for change the terminology so that "root >>> entry" isn't in the javadoc? >> I’ve released a new webrev, >> http://cr.openjdk.java.net/~sdrach/8132734/webrev.04/index.html<http://cr.openjdk.java.net/~sdrach/8132734/webrev.04/index.html> >> that addresses the above issue. >> >
