Also small thing: > Spliterator.NONNULL & Spliterator.IMMUTABLE
Should be Spliterator.NONNULL | Spliterator.IMMUTABLE With best regards, Tagir Valeev. On Fri, Sep 2, 2016 at 2:41 PM, Patrick Reinhart <patr...@reini.net> wrote: > On 2016-09-02 08:09, Andrej Golovnin wrote: > >> src/java.base/share/classes/java/lang/ClassLoader.java >> >> The constant RESOURCE_CHARACTERISTICS in the line 215 should be >> defined near the #streamOf()-method. The distance between the line >> 1412 where the #streamOf()-method is defined and the line 215 is just >> too huge. >> > > No problem, moved to the method itself > > Your patch seems to modify the JavaDocs of the methods #getParent(), >> #getPlatformClassLoader(), #getSystemClassLoader(). But I don see how >> it is related to the issue you try to solve.> >> > > Was a merge issue, removed those > > test/java/lang/ClassLoader/resources/ResourcesFailureCase.java >> test/java/lang/ClassLoader/resources/ResourcesSuccessCase.java >> > > The indentation is broken. You use tabs. But in JDK you must use >> spaces, see >> http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.ht >> ml#toc-indentation >> > > Fixed those also. > > See updated webrev: > > http://cr.openjdk.java.net/~reinhapa/reviews/8161230/webrev.01 > > - Patrick >
