Hi Paul, On 07.09.2016 22:59, Paul Sandoz wrote: >> On 7 Sep 2016, at 13:14, Patrick Reinhart <patr...@reini.net> wrote: >> >> >> Hi Paul, >> >> With the change for https://bugs.openjdk.java.net/browse/JDK-8165563 >> that Mandy has sent to review here: >> >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-September/043363.html >> >> the method getSystemResources where systemResources method relies on, in >> my understanding should be working. >> >> If I'm correct I will make my enhancement dependent on JDK-8165563 >> > You are not blocked on JDK-8165563, the two can proceed independently. > > Just remove the method systemResources from your patch, we don’t need it as > Mandy noted, since JDK-8165563 will render redundant the methods > getSystemResource/getSystemResources and thus by extension would also render > redundant a new method systemResources. > > Paul.
Now I understand the points of Mandy. I updated the webrev accordingly http://cr.openjdk.java.net/~reinhapa/reviews/8161230/webrev.03 -Patrick