On 30/04/2018 17:29, mandy chung wrote:
The updated webrev looks good. A minor comment is that I assume you can remove the cast from Executable::declaredAnnotations if you leave Executable::getRoot in place.:The 3 x getRoot methods on ReflectAccess looks okay. An alternative would to create <T extends AccessibleObject> T getRoot(T obj) and a package private getRoot() method on AccessibleObject.Good idea. I updated the patch.
-Alan