Hi Alan,
Thanks for the review and suggestion.
The CSR and Webrev are updated.
webrev:
http://cr.openjdk.java.net/~rriggs/webrev-static-property-8066709/
csr:
https://bugs.openjdk.java.net/browse/JDK-8204235
On 6/16/2018 8:42 AM, Alan Bateman wrote:
On 13/06/2018 15:10, Roger Riggs wrote:
Hi Joe,
The CSR text is still in draft and got out of sync with the open
review and comments.
The updated apiNote clarifies that changes made through the
System.*property* methods
may not affect the value cached during initialization.
The implementation changes affect a very short list of properties.
The note on the methods is to raise awareness that individual
properties may have
different behavior and may be unpredictable.
Just catching up on this. I checked the CSR and the webrev (the latest
webrev was generated on June 6 so I hope that is the version we are
meant to look at).
The updated apiNote (CSR version) looks okay but I think the word
"internal" needs to be dropped as it comes with too many questions.
"may be cached during initialization or ..." should be okay. The
editing has meant the line lengths are a bit inconsistent so I assume
they can be fixed up before the change is pushed.
I see the original patch to SocksSocketImpl has been mostly reverted.
It looks correct now. The other usages look okay to me.
-Alan
