Hi, Roger

On 6/18/18 7:31 AM, Roger Riggs wrote:

The CSR and Webrev are updated.

webrev:
   http://cr.openjdk.java.net/~rriggs/webrev-static-property-8066709

* src/java.base/share/classes/java/lang/System.java :

Should the @implNote with the list of cached properties be added everywhere the @apiNote is being added ? Right now the @implNote is only added to getProperties().


* src/java.base/share/classes/jdk/internal/util/StaticProperty.java :

Nit:

  45     private StaticProperty() {
  46
  47     }

Maybe put this all on one line?


Otherwise, the change looks good to me.

-Brent

Reply via email to