> On 8 Feb 2019, at 23:42, Martin Buchholz <marti...@google.com> wrote:
> 
> ...
> 8195057: java/util/concurrent/CountDownLatch/Basic.java failed w/ Xcomp
> https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/CountDownLatch-Basic/index.html
>  
> <https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/CountDownLatch-Basic/index.html>

Looks fine. I initially thought that a @build tag would be needed, but
I ran the test and jtreg builds the required library dependencies
implicitly.

> 8215359: InnocuousForkJoinWorkerThread.setContextClassLoader needlessly
> throws
> https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/InnocuousForkJoinWorkerThread/index.html
>  
> <https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/InnocuousForkJoinWorkerThread/index.html>

Looks good. A positive test for setContextClassLoader(null) could be
added.

-Chris.

Reply via email to