Hi Martin,
On 9/02/2019 9:42 am, Martin Buchholz wrote:
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html
8195057: java/util/concurrent/CountDownLatch/Basic.java failed w/ Xcomp
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/CountDownLatch-Basic/index.html
https://bugs.openjdk.java.net/browse/JDK-8195057
Looks fine.
8215359: InnocuousForkJoinWorkerThread.setContextClassLoader needlessly
throws
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/InnocuousForkJoinWorkerThread/index.html
https://bugs.openjdk.java.net/browse/JDK-8215359
Looks fine.
8215363: needless signals in ForkJoinPool
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/forkjoin-signals/index.html
https://bugs.openjdk.java.net/browse/JDK-8215363
Can't comment - the code is unfathomable.
Still in limbo:
8203662: remove increment of modCount from ArrayList and Vector replaceAll()
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/replaceAll/index.html
https://bugs.openjdk.java.net/browse/JDK-8203662
If still in limbo why is this here?
8215249: Miscellaneous changes imported from jsr166 CVS 2019-02
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/miscellaneous/index.html
https://bugs.openjdk.java.net/browse/JDK-8215249
- CyclicBarrier.java
I'm surprised you can just rethrow a Throwable, when the method is not
declared to throw Throwable. We always used to have a rethrow(Throwable
t) helper method Is this some (fairly) new exception type inference
based on what it is in the try block?
- test/jdk/java/util/concurrent/tck/CyclicBarrierTest.java
Okay.
- test/jdk/java/util/Collection/IteratorMicroBenchmark.java
Can't comment. Please update copyright year to:
Copyright (c) 2007, 2019, Oracle ...
- test/jdk/java/util/Collection/RemoveMicroBenchmark.java
Okay. Please update copyright year to:
Copyright (c) 2007, 2019, Oracle ...
Thanks,
David
