Hi Alan, > > http://cr.openjdk.java.net/~clanger/webrevs/8213031.10/ > I see your other mail with v11 so I switch to that version.
Right. 😊 > > Ok, makes sense. I've updated the coding such that the zip's file owner > would be the default owner, in case it can be retrieved. > I think this is mostly right now. One thing to check is that you are > catching UOE whereas it's the PAE's cause that might be UOE. It's alright as it is. If you look at the source of AccessController.doPrivileged for a PrivilegedExceptionAction, you will see that RuntimeExceptions are caught and rethrown, not yielding a PAE. So I must catch UOE here explicitly because it's a RuntimeException. > > : > > I have updated the doc in module-info.java quite a bit. Please check. > > > > Is it time to work on the CSR now? How shall we proceed there? > > > The table items in L119-150 look fine, we just need to avoid really long > lines One minor comment on L123 is that it might be clearer if you drop > "created" from the sentence. > > L48-78 is a "wall of text" and links that I don't think will be easy for > most developers to read. Can I provide suggested wording for this part > of the spec? I'm just thinking that an alternative wording might help > avoid too much iteration on this. Sure, you're very welcome 😊 So, I'll be waiting for your input on that. Thanks Christoph
