> On May 31, 2019, at 9:33 AM, Daniel D. Daugherty > <daniel.daughe...@oracle.com> wrote: > > Thumbs up. > > Dan
Thanks. > > > On 5/31/19 8:02 AM, Roger Riggs wrote: >> +1 >> >> On 5/31/19 2:19 AM, David Holmes wrote: >>> Hi Kim, >>> >>> This seems reasonable to me. >>> >>> Thanks, >>> David >>> >>> On 31/05/2019 7:04 am, Kim Barrett wrote: >>>>> On May 30, 2019, at 3:58 PM, Roger Riggs <roger.ri...@oracle.com> wrote: >>>>> >>>>> Hi Kim, >>>>> >>>>> To ensure you see some messages in the case of timeouts, it would be >>>>> useful to call System.out.flush() after printing the message in >>>>> logProcess(). >>>> >>>> Good idea; added. >>>> >>>> full: http://cr.openjdk.java.net/~kbarrett/8219149/open.01/ >>>> incr: http://cr.openjdk.java.net/~kbarrett/8219149/open.01.inc/ >>>> >>>>> I'm ok with the timestamps, as is, though the Duration might be useful in >>>>> some cases. >>>> >>>> As I discussed with Roger, I want to keep the change simple for now, >>>> as we're not yet sure where to expend effort looking deeper. I think >>>> comparing timestamps in just a few cases will tell us a lot (possibly >>>> that we're looking in entirely the wrong place, in which case we might >>>> just undo this change).
