On Mon, 19 Oct 2020 17:26:56 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> This is from the mailing list: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067190.html >> >> --------- >> ### Progress >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> - [ ] Change must be properly reviewed >> >> ### Testing >> >> | | Linux x64 | Windows x64 | macOS x64 | >> | --- | ----- | ----- | ----- | >> | Build | ✔️ (5/5 passed) | ✔️ (2/2 passed) | ✔️ (2/2 passed) | >> | Test (tier1) | ✔️ (9/9 passed) | ✔️ (9/9 passed) | ✔️ (9/9 passed) | >> >> >> >> ### Download >> `$ git fetch https://git.openjdk.java.net/jdk pull/714/head:pull/714` >> `$ git checkout pull/714` > > Hi Jon, > > Can you explain what this change is about: e.g. something like: > >> Updates the documentation of `Map::compute` to match its default >> implementation: >> The documentation of the default implementation of `Map::compute` was both >> wrong and confusing. >> This change updates the documentation to match the behaviour of the >> implementation. > > because now I am confused. I believe what you are trying to do is what I have > written above. Can you confirm? > This will need a CSR. > > And are you going to withdraw https://github.com/openjdk/jdk/pull/451 now? > > best regards, > -- daniel Hi @dfuch, Thanks for reviewing my PR. You're absolutely correct about what this PR is about. Besides, I already closed #451. ------------- PR: https://git.openjdk.java.net/jdk/pull/714
