On Tue, 20 Oct 2020 23:54:08 GMT, John Lin <github.com+1290376+johnl...@openjdk.org> wrote:
>> Hi Jon, >> >> Can you explain what this change is about: e.g. something like: >> >>> Updates the documentation of `Map::compute` to match its default >>> implementation: >>> The documentation of the default implementation of `Map::compute` was both >>> wrong and confusing. >>> This change updates the documentation to match the behaviour of the >>> implementation. >> >> because now I am confused. I believe what you are trying to do is what I >> have written above. Can you confirm? >> This will need a CSR. >> >> And are you going to withdraw https://github.com/openjdk/jdk/pull/451 now? >> >> best regards, >> -- daniel > > Hi @dfuch, > > Thanks for reviewing my PR. You're absolutely correct about what this PR is > about. Besides, I already closed #451. @dfuch May I ask how can I create a CSR? I checked https://wiki.openjdk.java.net/display/csr/CSR+FAQs and it says: > Q: How do I create a CSR ? > A: Do not directly create a CSR from the Create Menu. JIRA will let you do > this right up until the moment you try to > save it and find your typing was in vain. Instead you should go to the target > bug, select "More", and from the drop > down menu select "Create CSR". This is required to properly associate the CSR > with the main bug, just as is done for > backports. However, I don't have an account at https://bugs.openjdk.java.net/ yet. Therefore, I don't see the "More" button on https://bugs.openjdk.java.net/browse/JDK-8247402. Could you please tell me how do I proceed? Thank you. ------------- PR: https://git.openjdk.java.net/jdk/pull/714
